fix(install): support nonstandard package tarball roots - #2264
Open
TheAlexLichter wants to merge 2 commits into
Open
fix(install): support nonstandard package tarball roots#2264TheAlexLichter wants to merge 2 commits into
TheAlexLichter wants to merge 2 commits into
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.31 MiB | 10.31 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.42 MiB | 4.42 MiB | +150 B (+0.00%) |
| NAPI (Linux x64) | Binary | 33.07 MiB | 33.07 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.72 MiB | 12.72 MiB | -332 B (-0.00%) |
vp (macOS ARM64) |
Binary | 7.64 MiB | 7.64 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.84 MiB | 3.84 MiB | +946 B (+0.02%) |
| NAPI (macOS ARM64) | Binary | 40.50 MiB | 40.50 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.97 MiB | 16.97 MiB | -328 B (-0.00%) |
vp (Windows x64) |
Binary | 8.35 MiB | 8.35 MiB | +1.00 KiB (+0.01%) |
vp (Windows x64) |
gzip -9 | 3.64 MiB | 3.64 MiB | +193 B (+0.01%) |
| NAPI (Windows x64) | Binary | 27.51 MiB | 27.51 MiB | +1.00 KiB (+0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.70 MiB | 10.70 MiB | +947 B (+0.01%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | +1 B (+0.00%) |
| Installer (Windows x64) | Binary | 4.44 MiB | 4.44 MiB | +1.00 KiB (+0.02%) |
| Installer (Windows x64) | gzip -9 | 2.08 MiB | 2.08 MiB | +240 B (+0.01%) |
liangmiQwQ
reviewed
Jul 27, 2026
liangmiQwQ
left a comment
liangmiQwQ
left a comment
Collaborator
There was a problem hiding this comment.
Just thinking about that right now and this seems a good fix. Can we add a snap test for this?
fengmk2
approved these changes
Jul 30, 2026
Member
|
@liangmiQwQ The unit tests included with this fix already cover this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes installing Yarn 1.22.19 through Vite+. Its tarball uses
yarn-v1.22.19/instead of the conventionalpackage/directory.With this PR, Vite+ now locates the extracted package directory when the conventional path is absent.
Resolves #2241